[icedtea-web] RFC: fix findbugs communal cloud jnlps

Omair Majid omajid at redhat.com
Fri Jan 6 08:28:03 PST 2012

On 01/06/2012 11:19 AM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2012-01-05 18:38]:
>> Hi,
>> It was recently brought to my attention that the jnlps listed at
>> http://findbugs.sourceforge.net/index.html (under the section "New")
>> are broken, throwing exceptions when trying to run.
>> The attached fixes the problems.
>> The first problem was that icedtea-web was trying to ensure that all
>> jnlps, including extension jnlps have a main class. I wonder what
>> other applications were broken by this check. This patch modifies
>> the check to only check for main class when a main class is possible
>> (applets and applications).
>> The second second problem was that (in the extension jnlp file) the
>> jnlp element did not contain a codebase attribute. IcedTea-Web tried
>> to add this null codebase when merging the jnlp file, causing an
>> exception. The patch simply ignores this null.
>> ChangeLog:
>> 2012-01-05  Omair Majid<omajid at redhat.com>
>>    * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>>    (initializeResources): Only throw exceptions about the main class not
>>    being found when the jnlp file can have a main class.
>>    (addToCodeBaseLoader): Dont try to process null URLs.
>> Any thoughts or comments?
> Looks good to me, OK for HEAD and 1.1.

I guess I should have been more explicit. This patch was only for HEAD. 
I have not tested 1.1 at all. I dont think the first problem will occur 
in 1.1 anyway since it does not support signed jnlp files.

I will test and post a patch for 1.1 separately.

Thanks for the review!


More information about the distro-pkg-dev mailing list