[RFC][icedtea-web] Plugin doesn't halt when required elements from JNLP files are missing.

Danesh Dadachanji ddadacha at redhat.com
Fri Jan 6 08:44:14 PST 2012


Looking at the plugin docs[1], <title> and <vendor> are required 
elements of <information>, without them the plugin should stop with a 
fatal error. Currently, icedtea-web just returns null from their 
respective getters and handles null accordingly. However it should not 
even reach that far. Here's a simple patch that throws a ParseException 
when not found.

+2012-01-06  Danesh Dadachanji <ddadacha at redhat.com>
+	Applications using JNLP files without a title or vendor section
+	still run, despite them being required elements.
+	* netx/net/sourceforge/jnlp/Parser.java:
+	(getInformationDesc): If title or vendor are not found in info,
+	a new ParseException is thrown.
+	* netx/net/sourceforge/jnlp/resources/Messages.properties: Add
+	PNoTitleElement and PNoVendorElement

Any comments? Is this okay for HEAD?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: title-vendor-required-01.patch
Type: text/x-patch
Size: 1396 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120106/50bc1f22/title-vendor-required-01.patch 

More information about the distro-pkg-dev mailing list