[RFC][icedtea-web] Plugin does not make JNLP's <information> available when using jnlp_href
dbhole at redhat.com
Fri Jan 6 11:49:32 PST 2012
You forgot to attach the patch :)
* Danesh Dadachanji <ddadacha at redhat.com> [2012-01-06 14:48]:
> The JNLP file's information elements are not available for use when
> using the plugin through the browser and jnlp_href. For example when
> access dialogs pop up, they try to use
> PluginBridge.getInformation(). This is set to return a new (and so,
> empty) ArrayList rather than the contents of the information tag. To
> test this, use this applet and click Open.
> I've setup the info instance var in the PluginBridge constructor to
> either be the JNLP file's info or to be a new ArrayList if jnlp_href
> is not being used.
> PluginBridge.getInformation() is no longer needed because the
> superclass's method does what we want so I've removed it. There was
> the following comment in the method:
> "Should we populate this list with applet attribute tags?"
> I left this as is for now because JNLPFile.getInformation's javadoc
> states it only returns the <information> tag's elements. It might
> cause some confusion/inconsistency with the javadoc if we were to
> store the applet's attribute here. If we were to add a
> PluginBridge.getInformation, it would be identical in
> implementation. Apart from this, I don't see the harm in adding the
> attributes to the info - they are visible to the public anyway
> through ^U! The "name" attribute could also be used if there is no
> <title> so it might be useful to do so.
> I've also added "(unverified)" to the ends of the Publisher label of
> access dialogs because this can easily be spoofed.
> +2012-01-06 Danesh Dadachanji <ddadacha at redhat.com>
> + Use the JNLP file's information section for the Name and
> + Publisher labels of access dialogs, if available.
> + * netx/net/sourceforge/jnlp/PluginBridge.java:
> + (PluginBridge): Assigned info variable to JNLP file's information
> + section (if one is used), otherwise to a new, empty ArrayList.
> + (getInformation): Removed method, superclass method
> + should be used instead.
> + * netx/net/sourceforge/jnlp/resources/Messages.properties:
> + Adding SUnverified.
> + * a/netx/net/sourceforge/jnlp/security/AccessWarningPane.java:
> + (addComponents): Append unverified note to the publisher label.
> Thoughts/comments? If this is alright, I'd like to push it to HEAD.
>  http://docs.oracle.com/javase/tutorial/deployment/doingMoreWithRIA/examples/dist/applet_JNLP_API/AppletPage.html
More information about the distro-pkg-dev