ARM: Enable safepoints for JIT-compiled code
Dr Andrew John Hughes
ahughes at redhat.com
Wed Jan 11 05:26:03 PST 2012
On 13:11 Wed 11 Jan , Andrew Haley wrote:
> On 01/11/2012 01:05 PM, Dr Andrew John Hughes wrote:
> > On 14:31 Tue 10 Jan , Andrew Haley wrote:
> >> I've found the bug that broke safepoints. It turns out that safepoints
> >> do not convert a PC address to a bytecode index, so you have to set the
> >> bytecode pointer explicitly whenever at a safepoint. I'm intend to apply
> >> this to trunk and branch, given RM approval.
> > Patches to branches require approval by one other developer, not specifically
> > the release manager.
> They require at least RM approval, for the obvious practical reasons.
I'm not sure what 'obvious practical reasons' you're referring to, but no they don't,
and haven't for about the last two years. It would have been a tremendous bottleneck
if this was the case. Also what happens in the case that the maintainer of the branch
submits a patch? Should they get the right to dump whatever they want on the branch,
but block the work of others? I don't think that's fair, which is why all release patches
have required approval by another developer, regardless of author, for some time.
> It doesn't make much sense for technical reviews (for correctness,
> appropriateness, and so on) to be done on the release branch patches:
> that should get done on trunk.
This doesn't happen. It would be nice if it did, but it just doesn't on IcedTea.
We do seem to have managed it with IcedTea-Web, mainly because it was there from the
start, but there's also a smaller pool of committers there (mainly Deepak, Omair and
Jiri from what I've seen).
> The only matter for the branch is
> whether that patch is appropriate for the branch.
This we agree on. But that obviously requires understanding the impact of said patch.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120111/721b452f/attachment.bin
More information about the distro-pkg-dev