Reviewer needed - IcedTea6 HEAD: fixed some compiler warnings caused by using deprecated methods in JTReg tool
Dr Andrew John Hughes
ahughes at redhat.com
Thu Jan 12 08:52:34 PST 2012
On 10:56 Thu 12 Jan , Danesh Dadachanji wrote:
> Hi Pavel,
> Not your usual email address? =)
> The patch looks good, just a minor comment about the ChangeLog below.
> On 12/01/12 08:03 AM, Pavel Tisnovsky wrote:
> > Hi all,
> > I've made simple fixes in JTReg tool sources (in IcedTea6 HEAD ATM) to get rid of
> > compiler warnings due to use deprecated API methods. Output of hg diff is stored
> > in an attachment and here is the change log entry:
> > 2012-01-12 Pavel Tisnovsky<ptisnovs at redhat.com>
> > * src/jtreg/com/sun/interview/wizard/Wizard.java:
> > * src/jtreg/com/sun/javatest/EditJTI.java:
> > * src/jtreg/com/sun/javatest/TestSuite.java:
> > * src/jtreg/com/sun/javatest/agent/AgentFrame.java:
> > * src/jtreg/com/sun/javatest/batch/ObserverCommand.java:
> > * src/jtreg/com/sun/javatest/exec/BP_TestListSubpanel.java:
> > * src/jtreg/com/sun/javatest/exec/ET_FilterHandler.java:
> > * src/jtreg/com/sun/javatest/exec/LogViewerTools.java:
> > * src/jtreg/com/sun/javatest/exec/NewReportDialog.java:
> > * src/jtreg/com/sun/javatest/exec/QuestionLogBrowser.java:
> > * src/jtreg/com/sun/javatest/exec/TU_ViewManager.java:
> > * src/jtreg/com/sun/javatest/exec/TestTreePanel.java:
> > * src/jtreg/com/sun/javatest/tool/ConfigManager.java:
> > Fixed warnings caused by using deprecated methods.
> Could you s/java:/java,/ for all the files listed except the last one
> (ConfigManager.java), it looks like this is the convention for multiple
> files using the same description.
> Once that's fixed, the patch can be pushed to HEAD.
I'd rather we weren't making local changes to something that's maintained
elsewhere, and especially not just for a few compiler warnings.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120112/798ed3db/attachment.bin
More information about the distro-pkg-dev