ARM: Rewrite disassembler to use hsdis
omajid at redhat.com
Mon Jan 23 14:48:34 PST 2012
On 01/23/2012 04:12 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> On 01/23/2012 02:37 PM, Andrew Hughes wrote:
>>> I'm very wary about introducing Makefile changes into a release
>>> at such a late stage. How does these changes affect other
>> Not at all.
> These chunks would certainly seem to:
> +-CFLAGS += -fPIC
> ++CFLAGS += -fPIC -g
> +-CPPFLAGS += -I$(BINUTILSDIR)/include -I$(BINUTILS)/bfd -I$(TARGET_DIR)/bfd
> ++CPPFLAGS += -I$(BINUTILSDIR)/include -I$(BINUTILSDIR)/bfd -I$(TARGET_DIR)/bfd
> +- if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes; fi
> ++ if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes "CFLAGS=$(CFLAGS)"; fi
> As far as I can tell from the hard-to-read patch-within-a-patch, this part isn't within
> an ARM #ifdef.
> Have you posted this upstream yet? I'd be interested to hear Kelly's thoughts.
+1. This looks like something that should be upstream. FWIW, the impact
of the flags/changes is limited to the hsdis stuff though.
>>> Is hsdis part of a regular build?
>> No, hsdis is never built in any OpenJDK release.
> Ok, so how it is built? Just via icedtea-debug?
I did a debug-build and no *hsdis* file anywhere. Though (on x86_64) I
do see assembly printing after applying this patch.
-XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:+PrintCompilation
OpenJDK 64-Bit Server VM warning: PrintAssembly is enabled; turning on
DebugNonSafepoints to gain additional output
Could not load hsdis-amd64.so; library not loadable; PrintAssembly is
PrintAssembly request changed to PrintOptoAssembly
[ ... lots of assembler output removed ... ]
More information about the distro-pkg-dev