ARM: Rewrite disassembler to use hsdis
aph at redhat.com
Tue Jan 24 01:43:32 PST 2012
On 01/23/2012 10:48 PM, Omair Majid wrote:
> On 01/23/2012 04:12 PM, Andrew Hughes wrote:
>> ----- Original Message -----
>>> On 01/23/2012 02:37 PM, Andrew Hughes wrote:
>>>> I'm very wary about introducing Makefile changes into a release
>>>> at such a late stage. How does these changes affect other
>>> Not at all.
>> These chunks would certainly seem to:
>> +-CFLAGS += -fPIC
>> ++CFLAGS += -fPIC -g
>> +-CPPFLAGS += -I$(BINUTILSDIR)/include -I$(BINUTILS)/bfd -I$(TARGET_DIR)/bfd
>> ++CPPFLAGS += -I$(BINUTILSDIR)/include -I$(BINUTILSDIR)/bfd -I$(TARGET_DIR)/bfd
>> +- if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes; fi
>> ++ if [ ! -f $@ ]; then cd $(TARGET_DIR); make all-opcodes "CFLAGS=$(CFLAGS)"; fi
>> As far as I can tell from the hard-to-read patch-within-a-patch, this part isn't within
>> an ARM #ifdef.
>> Have you posted this upstream yet? I'd be interested to hear Kelly's thoughts.
Some of the patch adds ARM support, and this is done in the most
minimal way possible. Some of it is a backport from upstream, and
some of it is a bug that I'm discussing with John Rose who wrote
hsdis. This hunk simply makes sure that hsdis itself is built withe
None of this can possibly affect any IcedTea release, because hsdis is
never built as part of an IcedTea build on any architecture. It's
purely provided as a utility for people debugging IcedTea.
More information about the distro-pkg-dev