[RFC][icedtea-web] Use description param when creating a LaunchException

Danesh Dadachanji ddadacha at redhat.com
Tue Jan 31 12:59:40 PST 2012


I stumbled onto this while throwing an exception in my patch for single 
instance with jnlp_href. We never output the description parameter 
passed into the constructor of LaunchException. The message passed into 
the super call doesn't include it so the user will never see it.

I see no harm in adding the details to the message outputted when an 
exception is thrown. Currently, all the values passed as description are 
either direct empty strings or localized keys that have no text. Can we 
put it to some use? The patch mentioned above does so and perhaps this 
will encourage others to do so! =)

+2012-01-31  Danesh Dadachanji  <ddadacha at redhat.com>
+	* netx/net/sourceforge/jnlp/LaunchException.java: Add description
+	parameter to the message the exception stores.

Thoughts? Okay for HEAD?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: launch-exception-01.patch
Type: text/x-patch
Size: 679 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120131/99fa78dc/launch-exception-01.patch 

More information about the distro-pkg-dev mailing list