dbhole at redhat.com
Thu May 3 07:48:47 PDT 2012
* Jiri Vanek <jvanek at redhat.com> [2012-04-17 09:57]:
> This is reproducer for incorrect behaviour of icedtea-web when jnlps are in "unexpected" encoding.
> We are expecting utf-8 everywhere, but windows users can very easily
> expose jnlps in different one. And we should process them for unix
> user correctly.
> I have used ISO-8859-2 encoding to torture icedtea-web.
> All tests to this encoding have failed. I have added also set of
> UTF-8 tests above those cases, and all those are passing (so test
> should be correct).
> Sorry that diff is not in classical patch format, but diff tools
> have not cooperate well with mixed utf8/non-utf8 content. And it is
> just adding files so "applying" should be simple as with patch.
> Please note, that this adds 3 more passing and three more failing
> tests - which are representing the issue. Maybe annotation marking
> this "representatives" will become necessary soon?
Yes. Please let's work on a way of marking known failures in some way
first and letting the user know that they are expected to fail. I know
there was some talk of this but then I lost track and can no longer find
the thread :/
We should no longer check in anything that is known to fail without
fixing the issue first IMO.
> The name of the directory is so weird because I wanted to create
> resource containing those unhappy characters. (The engine creates
> I'm going to check this also for applets, but here launching
> informations are provided by brpwser so it should be ok.
> 2012-04-17 Jiri Vanek <jvanek at redhat.com>
> added encodings reproducer
> * tests/jnlp_tests/simple/encodingTestsĚŠČŘŽÝÁÍÉĚÉŘŤÝÚŮÍÓÁŠĎŽŹŇ: new reproducer
> * tests/jnlp_tests/simple/encodingTestsĚŠČŘŽÝÁÍÉĚÉŘŤÝÚŮÍÓÁŠĎŽŹŇ/srcs/encodingTest.java:
> main class and method of new encodingTestsĚŠČŘŽÝÁÍÉĚÉŘŤÝÚŮÍÓÁŠĎŽŹŇ.jar
> * tests/jnlp_tests/simple/encodingTestsĚŠČŘŽÝÁÍÉĚÉŘŤÝÚŮÍÓÁŠĎŽŹŇ/testcases/encodingTestTest.java:
> testcases for jnlps of this reproducers
> * tests/jnlp_tests/simple/encodingTestsĚŠČŘŽÝÁÍÉĚÉŘŤÝÚŮÍÓÁŠĎŽŹŇ/resources:
> three utf-8 and three iso-8859-2 jnlp files
More information about the distro-pkg-dev