[RFC][ICEDTEA-WEB] reproducer for pr955
ddadacha at redhat.com
Thu May 3 08:37:05 PDT 2012
On 20/04/12 07:38 AM, Jiri Vanek wrote:
> 2012-04-20 Jiri Vanek<jvanek at redhat.com>
> Reproducer for PR955
> * tests/jnlp_tests/simple/simpletest1/resources/simpletest1Localised.jnlp:
> New file, have localised information tags with not all required fields.
> * tests/jnlp_tests/simple/simpletest1/testcases/SimpleTest1Test.java:
> (testSimpletest1lunchWithLocalisedInformation) new testacese for above file
> Hi! This simple test is reproducing behaviour of pr955.
> However if it is doing the right way or not is discussable. Specification is clear that those elements are required. But proprietary
> plugin looks like taking default values from not-localised default one.
> So what do you think?
IMO we should accept localized ones, especially since proprietary does so.
The test looks good, those typos keep slipping in:
+ Assert.assertTrue(id + " stdout should contains " + s + " bud didn't", pr.stdout.contains(s));
s/should contains/should contain/ && s/bud didn't/but didn't
I have to ask again though, do we really want to add this before the fix is in? Having yet another test that's failing in HEAD does not
sound too good to me. :(
More information about the distro-pkg-dev