[Bug 1217] Add command line arguments for plugins

bugzilla-daemon at icedtea.classpath.org bugzilla-daemon at icedtea.classpath.org
Tue Nov 13 15:42:30 PST 2012


--- Comment #2 from Martin von Gagern <Martin.vGagern at gmx.net> ---
(In reply to comment #1)
> at this moment, there is currently a patch pending in review [1]
> which will allow you to set JVM options for plugins through itw-settings.

That sounds very good. Do you have a more recent version of that patch, which
addresses the issues pointed out in the responses to that post?

There are two more issue I noticed that hadn't been mentioned in these reviews:

+  if (to_trim == '\0'){
I guess you mean to_trim[0] or *to_trim.

+  g_spawn_command_line_sync(cmd_line_str, …)
Turning the whole command line into a single string might cause trouble if e.g.
appletviewer_executable contains a space. Using g_spawn_sync would avoid that,
and also save you from turning the array of arguments into a single string.

You could probably solve the problem of trimming your string at the same time
you split the string into words: simply omit any zero-length words from the
result. You can do simple word splitting using strtok, although that won't be
able to deal with quoted strings containing spaces.

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121113/a7297377/attachment.html 

More information about the distro-pkg-dev mailing list