[RFC][icedtea-web]: Set plugin JVM options in itw-settings

Saad Mohammad smohammad at redhat.com
Wed Nov 21 10:26:14 PST 2012

Thanks Adam and Omair for your feedback.

I improved the patch (mostly on the C++ side) and it now works well with
multiple jvm arguments. I removed the 'clean up' part from my earlier patch
since Omair pointed out it had been previously discussed and there was a
disagreement towards that approach.

Also to answer one of Omair's question, there are no user-visible performance
differences using this approach of spawning a JVM to retrieve arguments.

Bug Report: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1217

2012-11-21  Saad Mohammad  <smohammad at redhat.com>

	Added new option in itw-settings which allows users to set JVM
	arguments when plugin is initialized.
	* netx/net/sourceforge/jnlp/config/Defaults.java (getDefaults):
	Added defaults for DeploymentConfiguration.KEY_PLUGIN_JVM_ARGUMENTS.
	* netx/net/sourceforge/jnlp/config/DeploymentConfiguration.java:
	Added new property (KEY_PLUGIN_JVM_ARGUMENTS) which stores the value of
	JVM plugin arguments.
	* netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java:
	(createMainSettingsPanel): Added JVM settings to the list of tabs.
	(createJVMSettingsPanel): Returns a new JVMPanel object.
	* netx/net/sourceforge/jnlp/controlpanel/JVMPanel.java:
	JVM settings panel.
	* netx/net/sourceforge/jnlp/resources/Messages.properties:
	Added a new items (CPJVMPluginArguments, CPHeadJVMSettings,
	* plugin/icedteanp/IcedTeaNPPlugin.cc:
	(plugin_start_appletviewer): Adds JVM arguments to the commands that
	initalize it.
	(get_jvm_args): Returns JVM arguments set in itw-settings.
	(tokenize_char_to_vector): Split string into vector<gchar*> separated by
	newlines and spaces.

Saad Mohammad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changelog0-2.patch
Type: text/x-patch
Size: 1351 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121121/65321284/changelog0-2.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implementation0-2.patch
Type: text/x-patch
Size: 14766 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121121/65321284/implementation0-2.patch 

More information about the distro-pkg-dev mailing list