[rfc][icedtea-web] Add helper for getting NetxPanel's by unique key

Adam Domurad adomurad at redhat.com
Tue Jun 4 07:44:29 PDT 2013

Sorry for duplicate, forgot to send to list.

On 06/04/2013 02:32 AM, Jiri Vanek wrote:
> On 06/03/2013 06:04 PM, Adam Domurad wrote:
>> Hi all. This mostly makes sense in the context of a patch that Jiri
>> Vanek is working on. This adds a missing piece needed to operate on
>> all NetxPanel's with a given unique key.
>> To get the NetxPanel's from
>> UnsignedAppletTrustConfirmation.checkUnsignedWithUserIfRequired just do:
>> List<NetxPanel> appletPanels =
>> PluginAppletViewer.getAppletPanelsWithUniqueKey(file.getUniqueKey());
>> ChangeLog:
>> 2013-06-03 Adam Domurad <adomurad at redhat.com>
>> * netx/net/sourceforge/jnlp/NetxPanel.java
>> (getUniqueKey): New, returns applet unique key.
>> (getThreadGroup): Use getUniqueKey.
>> (NetxPanel): Use getUniqueKey.
>> * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java:
>> (getAppletPanelsWithUniqueKey): New, get all applet panels with a
>> given unique key.
>> Pushing probably depends on how useful it is to Jiri.
>> Happy hacking,
>> -Adam
> I think there is an issue that I can not use PluginAppletViever from
> netx where the splash code is placed.

Good point.

> Also isn't the synchronisation redundant?

Nope. Iterating over Vector is not by itself thread-safe, there can 
still be a concurrent modification.

> Do you mind If I get inspired by your code encapsulate it in my patch
> instead of bubbling the NetxPanel?

Of course! IMO you should keep this list in NetxPanel and have it 
updated on applet create, destroy etc. This way PluginAppletViewer will 
still indirectly control it.

> J.


More information about the distro-pkg-dev mailing list