[rfc][icedtea-web] Fix wrongly placed object construction helpers in IcedTeaScriptablePluginObject

Adam Domurad adomurad at redhat.com
Wed Jun 5 12:55:09 PDT 2013

On 06/05/2013 03:49 PM, Adam Domurad wrote:
> On 06/05/2013 03:48 PM, Adam Domurad wrote:
>> On 06/05/2013 10:34 AM, Adam Domurad wrote:
>>> Whoever wrote these static helpers switched up which class they are 
>>> associated with -- it took me a while of being confused to notice 
>>> it, too. This patch places the object creation helper methods in the 
>>> right class.
>>> I added some more type safety too to prevent future confusion.
>>> No changelog yet, I'll wait for an ack on the patch first.
>>> Cheers,
>>> -Adam
>> Here is additional refactoring on top of this patch and the 
>> '[rfc][icedtea-web] More testing for IcedTeaScriptablePluginObject.cc 
>> + memory leak fixes' fix patch. This stuff is necessary cleanup in my 
>> opinion; this code has been neglected.
>> Again changelog waiting for ack, I recommend using a tool like eg 
>> meld to look at the differences here. They are all safe and minor IMO.
>> The reason for touching this code is to try to make the 'getvalue' 
>> npapi call non-blocking, so it will never hang firefox.
> To clarify, the reason for the refactoring is to make way for a nicer 
> patch for this. This patch does not accomplish it yet.

Ugh, forgot the patch as well in my hurry, here it is.

>> Cheers,
>> -Adam

-------------- next part --------------
A non-text attachment was scrubbed...
Name: refactor-icedteascriptable.patch
Type: text/x-patch
Size: 17823 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130605/2289d5ea/refactor-icedteascriptable.patch 

More information about the distro-pkg-dev mailing list