[rfc][icedtea-web] Stripping semicolon tags from jar urls

Jiri Vanek jvanek at redhat.com
Fri Jun 7 02:31:51 PDT 2013

On 06/06/2013 09:01 PM, Andrew Azores wrote:
>> Unittests do also have strange indentation. Are you using some formatting tool? Both Netbens and
>> Eclipse can do the job for you.  In icedtea-web is .settiings directory with config files for ITW
>> if you wont.
>> After above is fixed, then I will push for you.
> Ooh, I  hadn't noticed that. Part of this was done in Eclipse and part of it was in Vim, and I guess
> my vimrc setup is not quite right. I'll go take a look at that.
>> Also one more nit. As separate changeset, can you please
>> extract the:
>>                          p = URLDecoder.decode(p, "UTF-8");
>>                          p = p.replaceAll("\\?.*", "");
>>                          p = (".".concat((p.endsWith("/")) ? p.concat("index.html") :
>> p)).replace('/', File.separatorChar);
>>                         p = stripHttpPathParams(p);
>> (and maybe few more lines)
> Sure, I'll do that next.
> New patches attached are same changeset as last time, just cleaned up indentation and the rest of
> the things you mentioned.
> Andrew A

Hi! Would be pushed by now, but you made one regression  against previous version

In attempt to avoid usage of ** APPLET..*** consatnts, you removed it: By doing this you made the 
mistake which will cause to run your browser test apreox 20s instead of one two or three.

The regression is in file tests/reproducers/simple/StripHttpPathParams/srcs/StripHttpPathParams.java

And the reason of this is method public void testStripHttpPathParamsApplet() throws Exception

I will let you figure out what and why have been broken, as it is crucial for you to understand the 
mechanism of  (closing)listners in testsuite.

But feel free to ping me or adam!

Good luck, J.

More information about the distro-pkg-dev mailing list