[rfc][icedtea-web] fix (And tests) for PR1473

Adam Domurad adomurad at redhat.com
Mon Jun 10 13:10:03 PDT 2013

On 06/10/2013 11:24 AM, Jiri Vanek wrote:
> This patch is removing the redownloading of jnlp file - both from local
> file and form network, and
> so fixing the  http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1473
> The unhappy redownloading was added during one of inital pushes -
> http://icedtea.classpath.org/hg/icedtea-web/rev/1d604ccd9b6b  And I'm
> wondering why:)
> J.

OK this patch left me a bit confused, file.getSourceLocation() is the 
location of the href, we are correctly redownloading from here to get 
the most up-to-date JNLP. However we can skip this check based on the 
update policy, and if we are already downloading from a network location 
(and we should, too).

Your tests seem to fail because the JNLP from the href is attempting to 
be downloaded -- but this is correct behaviour. Can you explain ?


More information about the distro-pkg-dev mailing list