[icedtea-web][rfc] Move stream closing utility in JNLPClassLoader to StreamUtils
adomurad at redhat.com
Tue Mar 5 13:27:06 PST 2013
On 03/05/2013 04:04 PM, Omair Majid wrote:
> Hi Adam,
> On 03/05/2013 03:47 PM, Adam Domurad wrote:
>> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader: move closeStream
>> to StreamUtils.closeSilently, update usages.
>> * netx/net/sourceforge/jnlp/util/StreamUtils: New method closeSilently,
>> closes stream, catching IOException.
> Something like this is better style:
> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> (closeStream): Remove.
> (verifySignedJNLP): Make use of StreamUtils instead.
> * netx/net/sourceforge/jnlp/utils/StreamUtils.java
> (closeSilently): New method.
Thanks, I'll use that and take note for next time.
>> + /***
>> + * Closes a stream, without throwing an exception
> Please add a note saying that exceptions will be printed and not just
Added. Also adjusted to only catch IOException, which is better on
> Otherwise looks fine to me.
OK to push ?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2614 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130305/a9dfdb56/remove-close-stream2.patch
More information about the distro-pkg-dev