[rfc][icedtea-web] a new reproducer for LiveConnect J->JS "get" tests

Adam Domurad adomurad at redhat.com
Wed Mar 6 09:50:19 PST 2013

This isn't what your subject line says it is :-)

On 03/06/2013 10:58 AM, Jana Fabrikova wrote:
> Hello,
> please see the attached patch of new reproducer for J->JS "evaluating 
> by calling JS eval from J".

The patch itself looks good, but what was the motivation for this ? IMHO 
we do not need more than one reproducer that tests eval, which we 
already have (JSObjectFromEval). From our point-of-view it's sending a 
string to the javascript engine. All the specific object conversion 
stuff should be handled with unit tests (this may require a bit of 
refactoring to support, but should be do-able).

Are you working on all these patches concurrently ? If not it'd be 
better to post them to list for feedback as you finish them, instead of 
all at once. Not a huge deal, though.

 > [..snip..]

Happy hacking,

More information about the distro-pkg-dev mailing list