[rfc][icedtea-web] Don't be silent if JNLPClassLoader gets a ClassFormatError
adomurad at redhat.com
Tue Mar 19 12:42:54 PDT 2013
On 03/19/2013 03:19 PM, Jiri Vanek wrote:
> On 03/19/2013 05:00 PM, Adam Domurad wrote:
>> I think this is worthy because it would have saved me a lot of time
>> investigating a recent bug.
>> This will continue as normal, but ClassFormatError's really should be
>> logged. It will make resulting ClassNotFoundException's less mysterious.
>> 2013-19-03 Adam Domurad <adomurad at redhat.com>
>> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>> (findClass): Print stacktrace for ClassFormatError
> Hmm... why keep other ones silent?
You mean PrivilegedActionException? It is worthy perhaps, shall I
include it when I push ? (NullJnlpFileException already stores the
exception and rethrows, and CNFE represents a failure that we fully
expect when we fail to load a classs.)
> Why do not rethrow?
Well my logic was simply to be as lenient as possible, eg in case we
ever pick something up that isn't really a class. However rethrow sounds
good to me too. If you prefer this I can do it (I do not expect it to
break anything, especially anything sanely organized). I looked at the
history of this catch and it is present in the initial commit, so no
telling why it was added.
More information about the distro-pkg-dev