[rfc][icedtea-web] LiveConnect tests which crash Opera

Jiri Vanek jvanek at redhat.com
Wed Mar 20 07:29:13 PDT 2013

On 03/18/2013 06:18 PM, Jana Fabrikova wrote:
> Hello,
> we have discussed with Jiri the testing of Java<->JavaScript communication via make
> run-netx-dist-tests and it appears that the LiveConnect tests crash the Opera browsers in such a way
> that it is not reasonable to run them every time.
> I have added several lines of code to the testcase files of all the pushed reproducers using
> LiveConnect (JSToJGet, JSToJSet, JSToJFuncParam and JSToJTypeConv) which let the tests in Opera pass
> without running the browser test, whenever the attribute doNotRunInOpera is set to "true" inside the
> testcase class,
> please see the attached patch,
> best regards,
> Jana


This looks ok. Althoug it is nasty hack :(( I do not think we can do better here...

Two nits - after them feel free to push, and dont forget to changelog :) (mentrion all changed 
files/functions..tabs.. blah blah :)
+//the JS<->J tests tend to make Opera unusable
+    public final boolean doNotRunInOpera = true;

Would be worthy of aligning.

+            Browsers b = server.getCurrentBrowser().getID();
+            if(b == Browsers.opera){

Imho worthy to comprim to one line:+
+            if(server.getCurrentBrowser().getID() == Browsers.opera){

But I do not insists.

Are those really all? Small change :) [do not forget to include also in future tests of JS api]


More information about the distro-pkg-dev mailing list