[rfc][icedtea-web] Don't be silent if JNLPClassLoader gets a ClassFormatError
omajid at redhat.com
Fri Mar 22 08:31:18 PDT 2013
On 03/22/2013 11:20 AM, Adam Domurad wrote:
> On 03/22/2013 11:15 AM, Omair Majid wrote:
>> On 03/22/2013 08:47 AM, Jiri Vanek wrote:
>>> I think it would be worthy to have printStackTrace in all catches in
>>> block you are modifying.
>>> Feel free to skip where you think it is redundant (nowhere?) and push.
>> Hm.. maybe it makes sense to print it for PrivilegedActionException. If
>> you add it for ClassNotFoundException (which is completely expected
>> during a lookup), it will just be noise.
> Hi Omair. I added it just for ClassFormatError, none of the other ones
> made sense. 90% of the ClassNotFoundException's were wrapped as
> PrivilegedActionException due to limitations with checked exceptions
> (<insert checked exception hate here>).
In some places, we actually unwrap PrivilegedActionException and check
what the underlying exception is. If you really care about the
PrivilegedActionExceptions which are not caused by
ClassNotFoundException, perhaps you can do that here too?
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev