[rfc][icedtea-web] Fix CacheReproducerTest

Jiri Vanek jvanek at redhat.com
Wed Sep 4 07:49:18 PDT 2013

On 09/04/2013 04:40 PM, Andrew Azores wrote:
> On 09/02/2013 05:22 AM, Jiri Vanek wrote:
>> >Nope, rather make it public. Anyaway, as others suggested, Can you
>> >tray to use DeploymentConfiguration singleton to get real location of
>> >cache. If you think it is good idea, then go with it.
> I've just gone and put it back to using the value out of the Defaults
> class. Maybe the DeploymentConfiguration idea can be put into a
> different test, but for now I'll just leave it with the "safe" Defaults

Why so?

> value. Also fixed some indentation and changed
> ServerAccess.ProcessResult to the non-deprecated ProcessResult - figured
> I might as well clear out the deprecation warnings while I was tinkering

Sure :)

> in there.
> Thanks,
> -- Andrew A
> CacheReproducerTest.patch
>                   }
> @@ -269,7 +271,7 @@
>           t.start();
>           Thread.sleep(1000);
>           pr = tryToClearcache();
> -        String q = "Can not clear cache at this time";
> +        String q = "Can not clear the cache at this time";

To aovid this in future I would suggest to load properties file and search by key. (yes you can
directly load messages.properties to local Properties variable) You can find inspiration in
Localisation tests.


Otehrwise looks good.

More information about the distro-pkg-dev mailing list