[rfc][icedtea-web] refactored logging
jvanek at redhat.com
Mon Sep 16 06:50:19 PDT 2013
On 09/13/2013 08:06 PM, Omair Majid wrote:
> On 09/13/2013 10:18 AM, Jiri Vanek wrote:
>> On 09/12/2013 07:09 PM, Omair Majid wrote:
>>> Are those exceptions worth logging? (or even worth stopping and showing
>>> an error to the user?)
>> Well thats the question. Which exception/message is which? There was
>> nearly thousand of substitutions... Can you imagine to evaluate each one?
> I suspect we will have to. Most of these are really-for-debugging
> messages. Some of they may be interesting to users, but most of them
> probably will not be.
Ok. As another chnagset please.
I really do not walk through all 700 stdout/err occurences manually again.
With logging bottleneck it will lead only to find usages.
Also - with this patch applied - I will quite easily find the wrong cases and start to meassure it.
Also I will keep it in mind when changing the itw settings.
> Otherwise we are syslog()ing all those (not-so-helpful) messages.
>> Anyway - four orriginally logged messages was nearly not worthy tobe
>> logged.... Then the Logger was moreover forgotten :(
> Sorry, I am not clear about this. Can you elaborate?
Originally the appletLog.log(..) was sused only in metxPanel.showAppletException(...) which is
override of openjdk's appletPanel.showAppletException()
The metxPanel.showAppletException(...) was adding the appletLog.log(..) and then call
super.showAppletException(...). The super showAppletException is used *only* on 8 palces in
openjdk's AppletPanel (which do only print stack trace and repaint). Those exceptions are extremely
rare and (Althoug maybe usefull for debugginng openjdk itself) are useless for debugging ITW.
The logger should help in both - with "my" refoctring it wil log both AppletPanel's exceptions and
>> TBH - personally I dont like java logging api - it is clumsy, and
>> actually not helping at all. Also I found it not suiting to ITW.
> Can you elaborate some more on this? What is it about the logging API
> that you think is not helping? I am only asking so I don't
> (accidentally) suggest repeating the issues.
> I am also a little confused. The only place that uses java.util.logging
> is Log (and AppletLog). As a complete aside, what are those 2 classes
> doing? Are they just used in one place (showAppletExceptions)?
Answered above. They were probably some attempt to log at least something from inside of plugin, but
not finished, and later forgotten. Actually bad luck:( They could serve earlier...
>> It loosk like wee need to solve the system level implementation asap,
>> otherwise some of mentioned questions cannot be answered correctly.
> I think that's a good idea. If we are making a change because it helps a
> future change, let's try and narrow down exactly what that future change is.
Work in progress.
In meanwhile, may we get the bottleneck inside? O:)
ps: its really needed. The widespread sout/err are terrible when one is getting to dig the information.
More information about the distro-pkg-dev