[icedtea-web] RFC: use Arrays.asList instead of custom implementation
omajid at redhat.com
Mon Sep 16 08:39:38 PDT 2013
On 09/16/2013 09:27 AM, Andrew Azores wrote:
> On 09/13/2013 05:19 PM, Omair Majid wrote:
>> There's a couple of places in icedtea-web where we are using a custom
>> method to do what's already being done by Arrays.asList. Lets remove
>> this 'duplicate' code.
> Looks good to me. Not sure how I feel about the "import static" for the
> UnsignedAppletTrustConfirmationTest, but no big deal.
Do you see a (potential) issue? Or do you (only) have a stylistic
concern? There was already a static import, so I added another.
Fixed in updated patch.
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4425 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130916/2399b47e/arrays-as-list-02.patch
More information about the distro-pkg-dev