[rfc][icedtea-web] net.sourceforge.jnlp.ResourcesTest fix

Omair Majid omajid at redhat.com
Mon Sep 16 08:54:23 PDT 2013

On 09/16/2013 10:15 AM, Andrew Azores wrote:
> On 09/13/2013 04:00 PM, Omair Majid wrote:
>> On 09/13/2013 02:46 PM, Andrew Azores wrote:
>>> Renamed some variables and removed an assertion that the user plugin
>>> directory (~/.mozilla/plugins) must exist, as it may not
>> Thanks for doing the cleanup. The code is so much more readable now!
>> If your IDE has refactoring support, please use that instead of renaming
>> things manually.
> nnoremap gr gd[{V%:s/<C-R>///gc<left><left><left>
> Now it has refactoring support ;)

Not really; proper refactoring support is based on parsing the code.
What you posted above won't work, for example, in the case of a
protected variable used by subclasses. Approximate 'refactoring' is
often very dangerous (especially in dynamically typed languages). This
is one of the reasons the first step of refactoring is generally writing
tests [1].

Patch itself looks okay to me.


[1] http://c2.com/cgi/wiki?TheFirstRefactoringStep
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list