[icedtea-web] RFC: Unit tests for JNLPProxySelector

Omair Majid omajid at redhat.com
Thu Sep 19 10:34:09 PDT 2013


The attached patch adds a bunch of unit tests for JNLPProxySelector.
Most functionality aside from making use of a PAC file should be covered
by tests now.

I tried to avoid making any functional changes, but it felt wrong to let
this one mistake go by:
- String host = uri.getSchemeSpecificPart().split(":")[0];
+ String host = uri.getHost();

Given the URI of "socket://example.org", the first line evaluates to
"//example.org", while the second one (correctly) evaluates to

Okay to push?


PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jnlpproxyselector-tests-01.patch
Type: text/x-patch
Size: 21580 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130919/714a7d95/jnlpproxyselector-tests-01.patch 

More information about the distro-pkg-dev mailing list