[icedtea-web] RFC: Unit tests for JNLPProxySelector
jvanek at redhat.com
Mon Sep 23 08:58:49 PDT 2013
On 09/19/2013 07:34 PM, Omair Majid wrote:
> The attached patch adds a bunch of unit tests for JNLPProxySelector.
> Most functionality aside from making use of a PAC file should be covered
> by tests now.
> I tried to avoid making any functional changes, but it felt wrong to let
> this one mistake go by:
> - String host = uri.getSchemeSpecificPart().split(":");
> + String host = uri.getHost();
> Given the URI of "socket://example.org", the first line evaluates to
> "//example.org", while the second one (correctly) evaluates to
> Okay to push?
looks ok to me.
More information about the distro-pkg-dev