[rfc][icedtea-web] refactored logging

Jiri Vanek jvanek at redhat.com
Mon Sep 23 23:43:49 PDT 2013

On 09/23/2013 06:03 PM, Omair Majid wrote:
> On 09/23/2013 11:40 AM, Jiri Vanek wrote:
>> ok. Lifecycle II :)
>> Although I used hg mv and  --git , during development I screwed it
>> somewhere so renaming is not visible in patches :(
>> So main changes are:
>> old classes were moved:
>> AppletLog.java got moved to ../utils/logging/FileLog.java
>> Log.java got moved to /utils/logging/LogConfig.java
>> The names are now much more corresponding with old behaviour. The new
>> behaviour is same,  but the code was rewritten to be cleaner, work
>> faster.. and .. well to work at all :) /me cursing asu :(
>> The new ItwLogger which was so discussed  was renamed to
>> logging/OutputController.java. As it is better description of its
>> pusposses.
> Let's get this in and we can improve things later.
> If you have unit tests, please push them too. If not, please write new
> ones. For things like threads, not having unit tests may come back to
> bite us later.
> Some of the files have a copyright date of 2011. Unless the file is a
> rename, please update the date.
Thank you for green light!

Anyway - I will unittest before the push.

One possible improvement (related to this change set) :
There is  138 occurrences of log(Level level, Throwable s)
There is  67 occurrences of log(Throwable s)
The  log(Throwable s)  is call to   log(Level.ERROR_DEBUG, (Object) s);
and those log(Level level, Throwable s)  are mostly  log(Level.ERROR_ALL, throwable) calls

I was thinking about changing it to
There is 68  occurrences of log(Level level, Throwable s)
There is  138 occurrences of log(Throwable s)
where The  log(Throwable s)  will be call to   log(Level.ERROR_ALL, (Object) s)

What do you think?

Until your reply I will fix the headers and  continue to write uniitests.
After unittests are done, I will push this change set, and sent tests for separate review.

Thanx for cooperation!


More information about the distro-pkg-dev mailing list