[rfc][icedtea-web] refactored logging

Omair Majid omajid at redhat.com
Tue Sep 24 07:31:07 PDT 2013

Hi Jiri,

On 09/24/2013 02:43 AM, Jiri Vanek wrote:
> One possible improvement (related to this change set) :
> There is  138 occurrences of log(Level level, Throwable s)
> There is  67 occurrences of log(Throwable s)
> The  log(Throwable s)  is call to   log(Level.ERROR_DEBUG, (Object) s);
> and those log(Level level, Throwable s)  are mostly 
> log(Level.ERROR_ALL, throwable) calls
> I was thinking about changing it to
> There is 68  occurrences of log(Level level, Throwable s)
> There is  138 occurrences of log(Throwable s)
> where The  log(Throwable s)  will be call to   log(Level.ERROR_ALL,
> (Object) s)
> What do you think?

I think this is one of those decisions where having some data would
allow for a better evaluation. Is the code calling log(Throwable)
expecting it to be user-facing or merely debugging information ?

PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list