[rfc][icedtea-web] refactored logging

Jiri Vanek jvanek at redhat.com
Tue Sep 24 10:12:15 PDT 2013

On 09/24/2013 04:31 PM, Omair Majid wrote:
> Hi Jiri,
> On 09/24/2013 02:43 AM, Jiri Vanek wrote:
>> One possible improvement (related to this change set) :
>> There is  138 occurrences of log(Level level, Throwable s)
>> There is  67 occurrences of log(Throwable s)
>> The  log(Throwable s)  is call to   log(Level.ERROR_DEBUG, (Object) s);
>> and those log(Level level, Throwable s)  are mostly
>> log(Level.ERROR_ALL, throwable) calls
>> I was thinking about changing it to
>> There is 68  occurrences of log(Level level, Throwable s)
>> There is  138 occurrences of log(Throwable s)
>> where The  log(Throwable s)  will be call to   log(Level.ERROR_ALL,
>> (Object) s)
>> What do you think?
> I think this is one of those decisions where having some data would
> allow for a better evaluation. Is the code calling log(Throwable)
> expecting it to be user-facing or merely debugging information ?

I believe all those exceptions are moreover deadly, rare or serious.. Not sure if this helps:)


More information about the distro-pkg-dev mailing list