[icedtea-web] RFC: Unit tests for BrowserAwareProxySelector

Omair Majid omajid at redhat.com
Tue Sep 24 11:46:07 PDT 2013


The attached patch adds unit tests for BrowserAwareProxySelector and
makes minor changes to make testing it easier.

It also removes duplicate logic of selecting a host and port depending
on the protocol into JNLPProxySelector.getFromArguments. The semantics
of 'sameProxy' are different between BrowserAwareProxySelector and
JNLPProxy selector; the socks proxy is included in firefox [1].

I wrote and ran all the unit tests /before/ the duplicate-removal.


[1] http://kb.mozillazine.org/Network.proxy.share_proxy_settings
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser-aware-proxy-tests-01.patch
Type: text/x-patch
Size: 21936 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130924/4ed8eb8a/browser-aware-proxy-tests-01-0001.patch 

More information about the distro-pkg-dev mailing list