[rfc][icedtea-web] Archive URL wrongly resolved - PR1204

Omair Majid omajid at redhat.com
Wed Sep 25 14:32:09 PDT 2013

On 09/25/2013 05:09 PM, Andrew Azores wrote:
> On 09/25/2013 03:55 PM, Omair Majid wrote:
>> One request for future patches: please keep the changelog in the format
>> that you will add to the ChangeLog file.
> Hmm? Did the formatting come out weird?

Yes, the lines look a little strange:

It's not a big deal, though.

> +            testQueryForBrowserProxyUsesHttpFallback(uri, result);
> +            String hierarchicalPath = result.getAuthority() + result.getPath();
> +            testQueryForBrowserProxyContainsNoDoubleSlashes(hierarchicalPath);
> +            testQueryForBrowserProxyDoesNotChangeQuery(uri, result);

I meant these three as separate @Test methods. What have you have done
is okay too, but it might be better to rename the methods to be assert*
(like assertUrlFallsBackToHttp) to reflect what they are doing.

> +    // Test that only HTTP is used as fallback scheme if a protocol other than HTTP(S) or FTP is specified
> +    public void testQueryForBrowserProxyUsesHttpFallback(URI expected, URI result) {

> +    // Test that absolute resource paths do not result in double-slashes within the URI
> +    public void testQueryForBrowserProxyContainsNoDoubleSlashes(String uri) {

> +    // Test that the query string of the URI is not changed
> +    public void testQueryForBrowserProxyDoesNotChangeQuery(URI expected, URI result) {

Otherwise okay to me. I am still not comfortable enough with the
reproducers to think that I have reviewed it, but otherwise feel free to
push with the suggestions above.


PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list