[rfc][icedtea-web] PR1592 reproducers update

Andrew Azores aazores at redhat.com
Thu Jan 9 08:17:23 PST 2014

On 01/03/2014 02:43 PM, Andrew Azores wrote:
> Updated PR1592 tests, using a custom reproducer rather than split simple/signed. This allows method calls to be made in the normal way as well as via reflection. JNLP includes both applications and applets now, and they close properly as well.
> (snip)
> Thanks,
> Andrew A

Went back over this and realized one of the tests was written wrong. The 
assertAccessControlException helper method in the testcase file is now a 
little stricter about the type of AccessControlException (so that the 
exceptions due to applets not being allowed to call System.exit don't 
falsely fulfill this assertion), and 
MixedSigningAppletHelper.attackDoPrivileged now properly calls 
MixedSigningAppletSigned#testSignedReadPropertiesDoPrivileged, as it 
should have been doing. In this case, the Unsigned JAR actually *is* 
meant to be able to retrieve data from the Signed JAR (as is the point 
of the AccessController.doPrivileged call), so the testcases now expect 
this test to successfully read from System.getProperty, rather than 
receive an AccessControlException. However, the tests still verify that 
in situations where the Signed JAR has a method call that involves a 
privileged action *without* being placed inside a doPrivileged call, an 
AccessControlException will be thrown if the Unsigned code attempts to 
access it, as expected.


Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr1592-reproducer-rewrite-custom2.patch
Type: text/x-patch
Size: 180614 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140109/c9d463c0/pr1592-reproducer-rewrite-custom2-0001.patch 

More information about the distro-pkg-dev mailing list