[rfc][icedtea-web] policytool in itweb-settings

Jacob Wisor gitne at gmx.de
Fri Jan 17 04:22:39 PST 2014

On 01/17/2014 11:35 AM, Jiri Vanek wrote:
>> [...]
>>> Please use File.createTmpfile(dir,pattern) instead :)
>>> It guarants you creation of the file, so you do not need to throw.
>> I didn't do this in the attached new patches, because I'm not sure about it.
>> This is going to create
>> temp files, eg in /tmp - do we really want to back up to here? If the power
>> goes out during a test
> nope :)
> Se again:   File.createTmpfile(dir,pattern). You can let it crate file in any
> dir -
> http://docs.oracle.com/javase/7/docs/api/java/io/File.html#createTempFile%28java.lang.String,%20java.lang.String,%20java.io.File%29
> Pls really use this instead of your schema.
> Also  - I have just found :
> policyBackup.renameTo(..)
> policyBackup.delete()
> It jsut do not have much sense to rename and then delte.. ORr what have I missed?

Plus, we have also covered this with that DirectoryValidator patch, as far as I 
recall. Some operating systems or file systems do not allow overwrite on rename, 
so you have to go for the atomic steps algorithm: delete backup -> copy current 
to backup name -> save or overwrite current from memory to disk


More information about the distro-pkg-dev mailing list