[rfc][icedtea-web] PR1592 reproducers update

Omair Majid omajid at redhat.com
Tue Jan 21 09:51:57 PST 2014

* Jiri Vanek <jvanek at redhat.com> [2014-01-21 06:27]:
> On seriosu flaw: you have "private static final ServerAccess server =
> new ServerAccess();" declard. by this you are owerwritting the one in
> BrowserTest, so no browser test will work, and wil fial 'can not lunch
> unset browser". 

That's not true. `server` is a static variable. It's not inherited [1].
Both `MixedSigningAppletSignedTests.server` and 'BrowserTest.server`
exist and refer to different things. A piece of code will have to
explicitly say `MixedSigningAppletSignedTests.server` to refer to the
variable in `MixedSigningAppletSignedTests`. A piece of code invoking
`BrowserTest.server` will get back the original object, not this
'inherited' one.

Not sure if the variable `server` still needs to be defined in the class
or not, but I just wanted to point out that it does not change the
variable declared in the parent class.

A question on style: why is the variable not `SERVER` instead of
`server`. It's `final`, right?


[1] http://stackoverflow.com/questions/17172033/java-and-inherited-static-members

PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list