[rfc][icedtea-web] PR1592 reproducers update
jvanek at redhat.com
Wed Jan 22 04:22:37 PST 2014
On 01/21/2014 06:51 PM, Omair Majid wrote:
> * Jiri Vanek<jvanek at redhat.com> [2014-01-21 06:27]:
>> On seriosu flaw: you have "private static final ServerAccess server =
>> new ServerAccess();" declard. by this you are owerwritting the one in
>> BrowserTest, so no browser test will work, and wil fial 'can not lunch
>> unset browser".
> That's not true. `server` is a static variable. It's not inherited .
Sorry. BAd wording. I had in mind: "is hiding inherited field"
> Both `MixedSigningAppletSignedTests.server` and 'BrowserTest.server`
> exist and refer to different things. A piece of code will have to
> explicitly say `MixedSigningAppletSignedTests.server` to refer to the
> variable in `MixedSigningAppletSignedTests`. A piece of code invoking
> `BrowserTest.server` will get back the original object, not this
> 'inherited' one.
> Not sure if the variable `server` still needs to be defined in the class
> or not, but I just wanted to point out that it does not change the
> variable declared in the parent class.
> A question on style: why is the variable not `SERVER` instead of
> `server`. It's `final`, right?
It was not static final at the beginning.
Thanx for keeping an eye.
More information about the distro-pkg-dev