[rfc][icedtea-web] Cache Locking Tests : Potential Deadlock Fix
jkang at redhat.com
Tue Oct 7 18:10:59 UTC 2014
----- Original Message -----
> This new patch looks fine to me.
> * Jie Kang <jkang at redhat.com> [2014-09-26 16:41]:
> > +++ b/tests/netx/unit/net/sourceforge/jnlp/cache/CacheTestUtils.java
> > @@ -0,0 +1,49 @@
> > +/* CacheEntryTest -- unit test for CacheEntry
> > + Copyright (C) 2014 Red Hat, Inc.
> Please fix this comment before pushing.
I did some more testing before pushing and noticed that our current 'make run-netx-unit-tests' attempts to run every java file as if it were a unit test. This means CacheTestUtils is attempted to be run and an exception is thrown since it contains no test methods. I've attached a patch that is the same as the prior patch except CacheTestUtils is now in test-extensions::net.sourceforge.jnlp.util which I think is a good spot for it. Just wanted to double-check here before pushing if you think that's a good place to put it or not.
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 19313 bytes
Desc: not available
More information about the distro-pkg-dev