[rfc] [icedtea-web] make PAthsAndFilles to follow seted paths III

Jie Kang jkang at redhat.com
Thu Apr 2 18:37:12 UTC 2015


Awesome work!

Nits below:

+        //setupable files have to override this
+        //if is desired to work with property, lets use known key. otherwise use 
+        //setter getter of this class
+        protected  String getPropertiesKey() {
+            return null;
+        }

For this comment, I read it a few times and I still don't fully understand it x-x;

Can you maybe reword it? From what I can tell, if you override it, people are able to set the property, otherwise it's read-only. Is that right? Is there anything else I am missing?

I think this may have been changed already but if not please:

+        this(PathsAndFiles.getRECENTLY_USED_FILE().getFile(), PathsAndFiles.CACHE_DIR.getFile());


That's it :D I don't see anything else. Looks good.


----- Original Message -----
> Hi!
> This patch is adding setter to InfrastructureFileDescriptor
> 99% of code  of it is moreover simple renaming. in PathsAndFiles
> Genrally  I added getPropertiesKey "nearly abstract method" to
> InfrastructureFileDescriptor. If
> overriden, then file is setupable in runtime.
> And it is much more comfortable to use FILE.setValue then all this
> Runtime.getConfig.setproperty(somekey)....
> After this patch is in, last small work will be on the way.
> I'm going to change
>   public CacheLRUWrapper(final File recentlyUsed, final File cacheDir) {
> to
>   public CacheLRUWrapper(final InfrastructureFileDescriptor recentlyUsed,
>   final
> InfrastructureFileDescriptor cacheDir) {
> It should do whole trick with setupable cache in unittests and finish the
> whole work about
> PathsAndFiles I hope.
> But it will need a lot of testing, so I'm keeping this second party of "[rfc]
> [icedtea-web] make
> PAthsAndFilles to follow seted paths III" for tomorrow
> Thank you for reviews!
> J.


Jie Kang

OpenJDK Team - Software Engineering Intern

More information about the distro-pkg-dev mailing list