[rfc][icedtea--web] fix itweb dual config mechanism broken by recent PathsAndFiles changes

Jiri Vanek jvanek at redhat.com
Thu Apr 9 15:17:47 UTC 2015


Today Iwonted to add "reset to default" button to temporary internet files pane in itweb settings 
(as it is heavily missing) and found, that I broke the system of change/(cancel x ok/apply) 
mechanism in itweb-settings.

This patch is adding the "reset button" and fixing this behaviour.

The issue is, that itweb-settings (then and only them) are  working with *two* config instances. So 
they canallow those cancel/apply schema. By moving to PathsAndFiles + getter/setter the second 
config was lost.

So I have reverted all those constructor(config) -> constructor() changes and added stub to 
PathsAndFiles which allows to set/get from those secondar prperties. Not nicest:-/

Maybe some abstraction like ItwebSettings configurable file ? Maybe I will find something tomorow, 
maybe reviwer will.

Still this is important to fix:(

-------------- next part --------------
A non-text attachment was scrubbed...
Name: madeITWEBSettingsToWorkAgain.patch
Type: text/x-patch
Size: 15159 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150409/f06656b2/madeITWEBSettingsToWorkAgain.patch>

More information about the distro-pkg-dev mailing list