[rfc][icedtea-web] use tagsoup (if avaible) also for signing jnlps.

Jiri Vanek jvanek at redhat.com
Mon Apr 13 10:05:55 UTC 2015

On 04/10/2015 06:05 PM, Jiri Vanek wrote:
> I recently got https://bugzilla.redhat.com/show_bug.cgi?id=1207437
> The jnlp is invalid, but tagsup cleans it so it runs. However the jnlp files inisde jars contains
> the same error, so they are not parsed, and so verification fails.
> I think, that those files should be treated as any other jnlp file used by app. That means to use
> tagsoup if used also for them, And dont if it is not used.
> The patch is doing four (very tightly connected) things:
> 1) Remove a lot of garbage in JNLPMatcher. The loading of xml can be done on two lines, not in
> twenty as it was.
> 2) use tagsoup(if used) on them
> 3) convert test to try-with-resources (and of course adapt to new design)
> 4) duplicate set of tests one set with tagsoup off and new set with tagsoup on.
> *note*
> testTemplateComments with tagsouop *ON* is failing!
> Currently I don't know why, and today I have not found it. It have to be fixed before release.
> This change (ad also the passwords for keystores) should go t 1.6 there is no need to postpon them
> to 1.7 And as they are change in behaviour, they should not go as minor update.
> Thanx!
>     J.
Just small update. After more investigations I had choosen @knowntofail for this test.

The comment inside element declaration is invalid anyway.  Added also two more tests to 
ParserCornerCases to escalate the issue. Also I found no simple workaorund around this issue:(
Also added comments.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanTemplateJnlps2.patch
Type: text/x-patch
Size: 57880 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150413/8dccb7c5/cleanTemplateJnlps2-0001.patch>

More information about the distro-pkg-dev mailing list