[rfc][icedtea-web] Add Tab Completion for icedtea-web

Jiri Vanek jvanek at redhat.com
Mon Apr 20 12:25:14 UTC 2015

On 04/17/2015 11:01 PM, Lukasz Dracz wrote:
> Hello,
> This patch adds a tab completion file to icedtea-web that can be installed in /etc/bash_completion.d/ by copying it over there by the user. I have also added it to be included in a tarball when make dist is called.
> The tab completion adds completion for javaws, itweb-settings and policyeditor.
> The options that are completed are completed with both the hyphen and non hyphen option. I think it would be better to just choose one for tab completing so the user does not see double the options every time they tab to see possible completions.
> I plan on adding a patch later that would replace the file with a make target, generated through a main method most likely in OptionsDefinitions.java and install it for the user.
> Thoughts ?
> Thank you,
> Lukasz Dracz

After isntalling bash-completion (is it expected?) this really worked for me. INteresting:)

Two major:
  1) I would include only -hyphen lead params. Its less verbosity , and much closer to what user expects. The duplication... it did not looked nicely.
  2) do you mind to include comment to this file, which will say "place this file to /etc/bash_completion.d/ or similar and isntall bash-completion or similar to make thsi file useful"

This would be nice to fix inchangeset after generation changeset. To allow (during configure) seupable isntall destination, which by default will be $PREFIX/etc/bash_completion.d/ But generation of this file first...
Are you going to use some kind of icedteaweb-completion.in or spew everything from main method? It actually seems to be good candidate for *.in file.

one major:
" local thermostat_install_dir" ?? :)))
  - anyway this, how yo hav it now, workd fine both for selfinstalle ditw, and same for installed itw. So"m not sure what it is for.


After all three issues fixed, ok to head. Or rather turn one more round :)


More information about the distro-pkg-dev mailing list