[rfc][icedtea-web] Add Tab Completion for icedtea-web
ldracz at redhat.com
Mon Apr 20 15:50:02 UTC 2015
> After isntalling bash-completion (is it expected?) this really worked for me.
> Two major:
> 1) I would include only -hyphen lead params. Its less verbosity , and much
> closer to what user expects. The duplication... it did not looked nicely.
Yeah I agree, made it hyphens only.
> 2) do you mind to include comment to this file, which will say "place this
> file to /etc/bash_completion.d/ or similar and isntall bash-completion or
> similar to make thsi file useful"
Added a comment on the top of the file
> This would be nice to fix inchangeset after generation changeset. To allow
> (during configure) seupable isntall destination, which by default will be
> $PREFIX/etc/bash_completion.d/ But generation of this file first...
> Are you going to use some kind of icedteaweb-completion.in or spew everything
> from main method? It actually seems to be good candidate for *.in file.
Hmm, not sure at the moment. The nice thing as I understand it with the main method is I can code
it to grab the latest options when run, so if a new option is added in
OptionsDefinitions there should be no need to update the tab completion file generation.
I'm not too familiar with *.in files. I know it is used as an input file.
What would you recommend ?
> one major:
> " local thermostat_install_dir" ?? :)))
> - anyway this, how yo hav it now, workd fine both for selfinstalle ditw,
> and same for installed itw. So"m not sure what it is for.
Good catch :), this line is not needed at all, I was editing the tab-completion file I used
for thermostat and I seemed to have missed this line.
> After all three issues fixed, ok to head. Or rather turn one more round :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1939 bytes
Desc: not available
More information about the distro-pkg-dev