<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 2010-03-04 13:13, Xerxes Rånby wrote:
<blockquote cite="mid:4B8FA3CE.2020606@zafena.se" type="cite">
<pre wrap="">The memory used for mattr during sharkCompiler::sharkCompiler can have
been reallocated before its contents are used because the args vector
refers to the mattr memory outside of matts valid scope. The attached
patch fixed this issue.
If you have got hit by this bug then you will see shark exit early with
an odd error messages like
": Unknown command line argument 't-failed-fuse-candidates'. Try: ' -help'"
because LLVM are trying to parse reused memory for its command line
arguments.
Ok to push?
Ok to push to icedtea6-1.7 release branch?
2010-03-04 Xerxes Rånby <a class="moz-txt-link-rfc2396E" href="mailto:xerxes@zafena.se"><xerxes@zafena.se></a>
* ports/hotspot/src/share/vm/shark/sharkCompiler.cpp
(sharkCompiler::sharkCompiler): Move mattr define to make its memory
valid in the scope where it are used by the args vector.
Cheers and have a great day!
Xerxes
</pre>
</blockquote>
Commited as:<br>
<a class="moz-txt-link-freetext" href="http://icedtea.classpath.org/hg/release/icedtea6-1.7/rev/546f16ad97d5">http://icedtea.classpath.org/hg/release/icedtea6-1.7/rev/546f16ad97d5</a><br>
and<br>
<a class="moz-txt-link-freetext" href="http://icedtea.classpath.org/hg/icedtea6/rev/c736cfc2dcb2">http://icedtea.classpath.org/hg/icedtea6/rev/c736cfc2dcb2</a><br>
<br>
After codereview by gnu_andrew ower irc:<br>
<span style="font-weight: normal;"><font size="2"><font color="#af7f00">(13.46.32)
</font></font></span><span
style="font-weight: bold; color: rgb(175, 127, 0);">gnu_andrew: </span>xranby,
ok looks good to me<br>
<br>
Thanks Andrew for the review!<br>
Cheers<br>
Xerxes<br>
</body>
</html>