Request for reviews (XS): 6714694: assertion in 64bit server vm (store->find_edge(load) != -1,"missing precedence edge")
Vladimir.Kozlov at Sun.COM
Mon Jun 16 15:44:02 PDT 2008
Thank you, Tom
I will add the test case and ran CTW.
Also I have to update the changes to include the fix
for the problem which exposed this bug.
MachNode::get_base_and_disp() does not process correctly
an addressing with a narrow oop LoadConN node (is_Con() == true).
As result the adr_type() for such addresses is "BotPTR* + bot"
which aliases with all stores.
I will resend the webrev with all changes.
Tom Rodriguez wrote:
> You need to run CTW for verify this. Also include the generated test as
> a regression test. Otherwise it seems reasonable.
> On Jun 16, 2008, at 2:58 PM, Vladimir Kozlov wrote:
>> Fixed 6714694: assertion in 64bit server vm (store->find_edge(load) !=
>> -1,"missing precedence edge")
>> The method raise_LCA_above_marks() terminates LCA search early
>> when mid->dom_lca(LCA) == mid which is already marked as visited.
>> Note: it is old problem not related to COOP.
>> Set visited mark after LCA's predecessors are put on the worklist.
>> Reviewed by:
>> Fix verified (y/n): y, failed test cases.
>> Other testing:
More information about the hotspot-compiler-dev