Request for review (XL): 6822110: Add AddressLiteral class on SPARC
Christian.Thalinger at Sun.COM
Tue Apr 21 09:47:28 PDT 2009
On Mon, 2009-04-20 at 09:52 -0700, Tom Rodriguez wrote:
> On Apr 19, 2009, at 12:54 PM, Christian Thalinger wrote:
> > On Fri, 2009-04-17 at 11:58 -0700, Tom Rodriguez wrote:
> >> The changes look ok, though there's a lot of renaming of Address a to
> >> Address a1 which isn't really an improvement.
> > Should I revert them? I thought it's helpful to have a variable name
> > that is different to the a for Address one before, al for
> > AddressLiteral.
> The al looked like a1 to me which just seemed odd. Going from one
> character to two doesn't do much for understanding so I'd either
> revert it or use something longer, like addrlit. Whatever you want to
> do is fine.
I did the latter and will commit that.
More information about the hotspot-compiler-dev