Request for reviews (XL): 6894206: JVM needs a way to traverse method handle structures

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Dec 4 09:19:56 PST 2009

On Fri, 2009-12-04 at 08:59 -0800, Vladimir Kozlov wrote:
> I think you should cast 'f' to jlong also:
> 427 #define ID4(x, y, z, f) ((ID3(x, y, z) << vmIntrinsics::log2_FLAG_LIMIT) | (int)(f))


>  > I integrated both changes but I omitted a check for flags as it seems
>  > not to be a simple assert.
> Why it is not simple ?:
> !     assert(flags_for(id) == Flags(flags), "correct id");

Well, I don't see how this should work.  The Flags enum has completely
different values than AccessFlags.

(dbx) p flags
flags = 257
(dbx) p flags_for(id)
flags_for(id) = F_R
(dbx) whatis F_R
enum Flags {..., F_R=1, ...};

> Also remove growableArray.hpp changes since Tom pushed his.

Yeah, this happens because I do the diffs on hotspot-comp but the
changes still have to apply to bsd-port/hotspot.  It's getting annoying.

-- Christian

More information about the hotspot-compiler-dev mailing list