Request for reviews (XXL): 6893268: additional dynamic language related optimizations in C2

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Dec 9 03:15:12 PST 2009

On Tue, 2009-12-08 at 17:11 -0800, Tom Rodriguez wrote:
> > and used the first one in places where it's appropriate.  Here is a
> > webrev of the changes:
> > 
> >
> > 
> > Could I roll that into this change?
> It seems overly complicated.  If the actual class name is java/dyn
> then you'll get a range check on the final byte_at(len) test.  Why not
> just require the trailing / and check it via asserts?

If John wants to add the feature he was talking about yesterday (to be
able to add packages via a command line option), I think we should make
it as robust as possible and add another check in

  // Test if the class name is something like "java/lang".
  if ((len + 1) > name()->utf8_length())
    return false

I like to have complete and robust class methods which do all the work
for you.

-- Christian

More information about the hotspot-compiler-dev mailing list