long_by_long_mulhi() rewritten and commented
rasbold at google.com
Mon Feb 2 08:59:39 PST 2009
Sure. If you create the CR, I'll review the webrev.
On Mon, Feb 2, 2009 at 8:54 AM, Christian Thalinger
<Christian.Thalinger at sun.com> wrote:
> On Mon, 2009-02-02 at 08:42 -0800, Chuck Rasbold wrote:
>> Christian -
>> I think your suggested change with attribution to Hacker's Delight is
>> a good idea. C2 already references that source elsewhere.
>> I would change the constants in the comments to match those used in
>> the building the ideal graph. Then note in a single place that you
>> adjusted Warren's algorithm to 64 bits.
> Yeah. Andrew Haley also said today on IRC that it's a bit confusing.
> Should I create a CR, make the changes and upload a webrev?
> -- Christian
More information about the hotspot-compiler-dev