for review (XXL): 6655638 method handles for invokedynamic
John.Rose at Sun.COM
Fri Feb 13 12:28:31 PST 2009
On Feb 13, 2009, at 12:13 AM, Christian Thalinger wrote:
> On Thu, 2009-02-12 at 14:41 -0800, John Rose wrote:
>> Yes, I wouldn't have done it that way, except that I'm following the
>> lead of existing code (java_lang_ref_Reference_fix_pre). Shall we
>> leave it as-is, or fix both? I could bind a local variable like
>> typeArrayHandle& fields = (*fields_ptr);
> I would fix both, but...
I'll fix both, but back out if someone complains. In general, I try
to apply cleanups as I go through the code, but if I'm not touching a
method at all I won't go into it just for cleanups. This is a
marginal case; I'll do it.
I recommend this policy for cleanups for the team in general, since
(a) the code is mature and therefore has lots of oddities to improve,
yet (b) we don't want to risk needless merge conficts by primping
otherwise unchanged lines.
At this point I know I'm inviting a whole new thread of conversation.
So, having gotten the attention of code artistes like me, I'll direct
you here: http://wikis.sun.com/display/HotSpotInternals/StyleGuide
>> I prefer the present formulation as simplest and most neutral in
>> connotations. But if there's a strong reason to change it in this
>> case, I'll do it.
> Not that I know of. I was just proposing.
Part of growing a hotspot coder community is making explicit and
public what has been implicit and/or Sun-internal so far. Such
suggestions help to do so...
More information about the hotspot-compiler-dev