Request for reviews (S): 6791572: assert("duplicating node that's already been matched")
Vladimir.Kozlov at Sun.COM
Thu Feb 19 18:57:24 PST 2009
I updated the fix after discussion with Tom.
Vladimir Kozlov wrote:
> Fixed 6791572: assert("duplicating node that's already been matched")
> AddP, LShiftX nodes and their inputs are marked as visited
> on x86 during the first address expression processing.
> AddP, LShiftX inputs will be not marked as shared since
> AddP, LShiftX will be marked as shared first.
> And this causes the problem since after AddP, LShiftX
> are folded into address expressions their inputs
> will be shared by several address expressions.
> Delay marking nodes as visited if they are inputs
> to an address expression.
> Reviewed by:
> Fix verified (y/n): y, test case
> Other testing:
More information about the hotspot-compiler-dev